Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework CLR reboot #1183

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Rework CLR reboot #1183

merged 1 commit into from
Jan 30, 2019

Conversation

josesimoes
Copy link
Member

Description

  • CLR_RT_ExecutionEngine instance is now always deleted on clean-up.
  • Add memset to clear all major strucst on clean-up.
  • Remove c_NoShutdown option from Monitor_Reboot.
  • Remove call to Abort threads and add developer notes about what is happening in ExecutionEngine_Cleanup.

Motivation and Context

  • The CLR reboot workflow wasn't being properly carried out.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Rework CLR reboot
c472e67 
- CLR_RT_ExecutionEngine instance is now always deleted on clean-up.
- Add memset to clear all major strucst on clean-up.
- Remove c_NoShutdown option from Monitor_Reboot.
- Remove call to Abort threads and add developer notes about what is happening in ExecutionEngine_Cleanup.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Breaking-change labels Jan 30, 2019
@nfbot
Copy link
Member

nfbot commented Jan 30, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes mentioned this pull request Jan 30, 2019
Merged
10 tasks
@josesimoes josesimoes merged commit c7efead into nanoframework:develop Jan 30, 2019
@josesimoes josesimoes deleted the rework-clr-reboot branch January 30, 2019 14:11
josesimoes
josesimoes commented Jan 30, 2019
View reviewed changes
targets/FreeRTOS/ESP32_DevKitC/nanoCLR/CLRStartup.cpp
// OK to delete execution engine
CLR_RT_ExecutionEngine::DeleteInstance();
}
CLR_RT_ExecutionEngine::DeleteInstance();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanoframework/esp32-developers this call seems to be preventing a debug session from starting.
I can't get hold on my debugger and I couldn't find the root cause. Just found that this seem to be the offending call by trial and error. Another possibility is that there is nothing wrong with the call and it just takes a bit too much to execute and VS debug provider quits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Breaking-change Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot